[ 
https://issues.apache.org/jira/browse/STORM-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239347#comment-14239347
 ] 

Frantz Mazoyer commented on STORM-248:
--------------------------------------

Thanks for the comment :-)

I would propose this as a fix, then:
    - Add storm.logback.conf.dir to storm.yaml.
    - In python script, for all daemons except supervisor, determine 
-Dlogback.configurationFile from storm.logback.conf.dir and pass it on to 
daemon as "-Dlogback.configurationFile=" + STORM_LOGBACK_CONF_DIR + 
"/cluster.xml".
      If not defined, fall back to default/usual storm logback directory 
pointing to cluster.xml  
    - In python script, for the supervisor, if defined, pass on 
"-Dstorm.logback.conf.dir=" + STORM_LOGBACK_CONF_DIR and 
"-Dlogback.configurationFile=" + STORM_LOGBACK_CONF_DIR + "/cluster.xml"
      Otherwise, fall back to default/usual storm logback directory pointing to 
cluster.xml  
    - In supervisor.clj, if storm.logback.conf.dir is defined, use is at root 
dir for worker.xml in launch command line; otherwise, fall back to 
default/usual storm logback directory pointing to worker.xml  

What do you think ?
Thanks again for the help :-)

> cluster.xml location is hardcoded for workers.
> ----------------------------------------------
>
>                 Key: STORM-248
>                 URL: https://issues.apache.org/jira/browse/STORM-248
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Edward Goslin
>            Assignee: Frantz Mazoyer
>            Priority: Trivial
>
> when the supervisor spawns a worker process, it assumes the cluster.xml is in
> -Dlogback.configurationFile=" storm-home "/logback/cluster.xml"
> It should take the VM arguement for the supervisor and pass it down to the 
> worker.
> System.get("logback.configurationFile", storm-home + "/logback/cluster.xml)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to