GitHub user BuDongDong opened a pull request:

    https://github.com/apache/storm/pull/348

    Update stats.clj "rolling-window-set" function, exchange the real argume...

    ...nt "num-buckets" and "s" of "rolling-window" function
    
    (defn rolling-window-set [updater merger extractor num-buckets & 
bucket-sizes]
    (RollingWindowSet. updater extractor (dofor [s bucket-sizes] 
(rolling-window updater merger extractor s num-buckets)) nil)
    )
    (defrecord RollingWindow [updater merger extractor bucket-size-secs 
num-buckets buckets])
    if not exchange the real argument ”num-buckets“ and "s" of 
“rolling-window” function, then the "bucket-size-secs" of RollingWindow is 
30/540/4320, and the "num-buckets" of RollingWindow is 20
    I think that the "bucket-size-secs" of RollingWindow is 20, and the 
"num-buckets" of RollingWindow is 30/540/4320.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BuDongDong/storm-1 master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/348.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #348
    
----
commit b827d660bf18f711da36012355c7d06e35b926e3
Author: zhangjinlong <[email protected]>
Date:   2014-12-15T08:50:50Z

    Update stats.clj "rolling-window-set" function, exchange the real argument 
"num-buckets" and "s" of "rolling-window" function
    
    (defn rolling-window-set [updater merger extractor num-buckets & 
bucket-sizes]
    (RollingWindowSet. updater extractor (dofor [s bucket-sizes] 
(rolling-window updater merger extractor s num-buckets)) nil)
    )
    (defrecord RollingWindow [updater merger extractor bucket-size-secs 
num-buckets buckets])
    if not exchange the real argument ”num-buckets“ and "s" of 
“rolling-window” function, then the "bucket-size-secs" of RollingWindow is 
30/540/4320, and the "num-buckets" of RollingWindow is 20
    I think that the "bucket-size-secs" of RollingWindow is 20, and the 
"num-buckets" of RollingWindow is 30/540/4320.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to