[
https://issues.apache.org/jira/browse/STORM-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246512#comment-14246512
]
ASF GitHub Bot commented on STORM-593:
--------------------------------------
GitHub user tedxia opened a pull request:
https://github.com/apache/storm/pull/349
STORM-593: remove endpoint-socket-lock for worker-data
PR for [STORM-593](https://issues.apache.org/jira/browse/STORM-593)
cached-node+port->socket in worker-data is atom, there on need for rwlock
endpoint-socket-lock to protect cached-node+port->socket. And after use rwlock,
there will be competition between refresh-connections and message send.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tedxia/incubator-storm
remove-endpoint-socket-lock
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/349.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #349
----
commit 5210fce329571da2b6121c8ba941d3c7774face1
Author: xiajun <xia...@xiaomi.com>
Date: 2014-12-15T09:56:53Z
remove endpoint-socket-lock in worker.clj
----
> No need of rwlock for clojure atom
> -----------------------------------
>
> Key: STORM-593
> URL: https://issues.apache.org/jira/browse/STORM-593
> Project: Apache Storm
> Issue Type: Improvement
> Affects Versions: 0.10.0
> Reporter: xiajun
> Assignee: xiajun
>
> cached-node+port->socket in worker-data is atom, there on need for rwlock
> endpoint-socket-lock to protect cached-node+port->socket. And after use
> rwlock, there will be competition between refresh-connections and message
> send.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
