Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/347#discussion_r21839632
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/SequenceFileBolt.java
---
@@ -108,7 +109,11 @@ public void execute(Tuple tuple) {
try {
long offset;
synchronized (this.writeLock) {
- this.writer.append(this.format.key(tuple),
this.format.value(tuple));
+ if (this.format instanceof SerializableSequenceFormat) {
--- End diff --
The new interface and type checking is only necessary for backwards
compatibility, you could change the return type of original SequenceFormat
interface to Object and no other code change will be necessary . I would add
that as a comment here so when we decide to do a major version bump we could
get rid of this extra code and the extra interface.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
