Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/356#issuecomment-67997939
  
    The changes look fine to me.  My only concern would be around what happens 
if the cache has not been updated and is empty, but it looks like it will 
return an empty map, and that looks like what happened before when there were 
no heartbeats.
    
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to