[ 
https://issues.apache.org/jira/browse/STORM-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14266771#comment-14266771
 ] 

ASF GitHub Bot commented on STORM-248:
--------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/373#discussion_r22552440
  
    --- Diff: bin/storm ---
    @@ -74,7 +74,8 @@ if (not os.path.isfile(os.path.join(USER_CONF_DIR, 
"storm.yaml"))):
     STORM_RELEASE_DIR = os.path.join(STORM_DIR, "RELEASE")
     STORM_LIB_DIR = os.path.join(STORM_DIR, "lib")
     STORM_BIN_DIR = os.path.join(STORM_DIR, "bin")
    -STORM_LOGBACK_FILE_PATH = os.path.join(STORM_DIR, "logback", "cluster.xml")
    +STORM_LOGBACK_DIR = os.path.join(STORM_DIR, "logback")
    +STORM_LOGBACK_FILE_PATH = os.path.join(STORM_LOGBACK_DIR, "cluster.xml")
    --- End diff --
    
    I don't think this is used any more.


> cluster.xml location is hardcoded for workers.
> ----------------------------------------------
>
>                 Key: STORM-248
>                 URL: https://issues.apache.org/jira/browse/STORM-248
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Edward Goslin
>            Assignee: Frantz Mazoyer
>            Priority: Trivial
>
> when the supervisor spawns a worker process, it assumes the cluster.xml is in
> -Dlogback.configurationFile=" storm-home "/logback/cluster.xml"
> It should take the VM arguement for the supervisor and pass it down to the 
> worker.
> System.get("logback.configurationFile", storm-home + "/logback/cluster.xml)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to