Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/373#discussion_r22597312
--- Diff: bin/storm ---
@@ -312,6 +312,13 @@ def repl():
cppaths = [CLUSTER_CONF_DIR]
exec_storm_class("clojure.main", jvmtype="-client", extrajars=cppaths)
+def get_logback_conf_dir():
+ cppaths = [CLUSTER_CONF_DIR]
+ storm_logback_conf_dir = confvalue("storm.logback.conf.dir", cppaths)
+ if(storm_logback_conf_dir == None or storm_logback_conf_dir == "nil"):
--- End diff --
Here storm_logback_conf_dir == "nil" will match if the
storm_logback_conf_dir is set to "nil" . I think you meant to check if the
string is empty, a better way probably is "if not storm_logback_conf"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
