Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/294#discussion_r22720641
  
    --- Diff: storm-core/src/saveVersion.sh ---
    @@ -0,0 +1,42 @@
    +#this file is used to generate the package-info.java class that
    +# records the version, revision, branch, user, timestamp, and url
    +unset LANG
    +unset LC_CTYPE
    +unset LC_TIME
    +version=$1
    +build_dir=$2
    +user=`whoami`
    +date=`date`
    +cwd=`pwd`
    +if [ -d ../.git ]; then
    +  revision=`git log -1 --pretty=format:"%H"`
    +  hostname=`hostname`
    +  branch=`git branch | sed -n -e 's/^* //p'`
    +  url=`git remote -v | sed -n -e 's/^origin\t\(.*\)(fetch)/\1/p'`
    --- End diff --
    
    '\t' does not work with all versions of sed.  The version that comes with 
Mac OS X for instance does not support it.  But all of them, supposedly support 
an actual tab character in the stream.  Could you replace the '\t' with an 
actual tab character? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to