Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/336#issuecomment-71215853
  
    @sasincj 
    I don't understand the EventHub system well enough to really be able to 
judge if the code is functioning properly in corner cases, etc.  I get at a 
high level what it does (http://azure.microsoft.com/en-us/services/event-hubs/) 
but I have never used it myself.  The code itself looks OK, but I am not 
comfortable voting on it either way with my current knowledge.  
    
    I am a bit nervous about pulling this in as we don't have a very good way 
to test it beyond the unit tests. EventHubs is a Microsoft Azure specific 
system.  I cannot spin up my own instance of it to validate that the code is 
doing what I expect prior to a release.  Although it may be a bit painful, I 
can do that for Kafka, Redis, HDFS, and HBase integration that we have accepted 
in so far.  That doesn't mean we cannot/should not pull it in.  To me it mostly 
means that we need more assurances and support prior to doing so. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to