[ 
https://issues.apache.org/jira/browse/STORM-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289443#comment-14289443
 ] 

ASF GitHub Bot commented on STORM-583:
--------------------------------------

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/336#issuecomment-71215853
  
    @sasincj 
    I don't understand the EventHub system well enough to really be able to 
judge if the code is functioning properly in corner cases, etc.  I get at a 
high level what it does (http://azure.microsoft.com/en-us/services/event-hubs/) 
but I have never used it myself.  The code itself looks OK, but I am not 
comfortable voting on it either way with my current knowledge.  
    
    I am a bit nervous about pulling this in as we don't have a very good way 
to test it beyond the unit tests. EventHubs is a Microsoft Azure specific 
system.  I cannot spin up my own instance of it to validate that the code is 
doing what I expect prior to a release.  Although it may be a bit painful, I 
can do that for Kafka, Redis, HDFS, and HBase integration that we have accepted 
in so far.  That doesn't mean we cannot/should not pull it in.  To me it mostly 
means that we need more assurances and support prior to doing so. 


> Add spout and bolt implementation for Azure Eventhubs
> -----------------------------------------------------
>
>                 Key: STORM-583
>                 URL: https://issues.apache.org/jira/browse/STORM-583
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.9.3
>            Reporter: shanyu zhao
>            Assignee: shanyu zhao
>             Fix For: 0.10.0
>
>         Attachments: Storm-EventHubsDesign.docx
>
>
> Add spout and bolt implementations for Azure Eventhubs - a messaging service 
> that supports AMQP protocol. Just like storm-kafka/storm-hbase, we need to 
> add the project to the /external folder.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to