Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/374#issuecomment-72685012
For the most part it looks OK. I am concerned about a few of the APIs seem
confusing to me and could use some better javadocs. Also I am concerned with
the performance of some of the sql involved. We are regenerating a lot of the
sql from text for each query. I am not a sql expert, but I thought that the
idea behind prepared statements was that it made it so the sql engine did not
have to reparse and compile the query each time. I'm not sure how each server
does that internally, but the fact that we are doing string manipulation for
each query instead of once when the bolt is prepared, seems problematic.
Also the Columns magic we are doing seems OK, but like I said I am not a
SQL expert and it feels like just using a stored query would be a lot simpler
then all of this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
