[ https://issues.apache.org/jira/browse/STORM-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307373#comment-14307373 ]
ASF GitHub Bot commented on STORM-441: -------------------------------------- Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/237#discussion_r24169370 --- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj --- @@ -14,25 +14,36 @@ ;; See the License for the specific language governing permissions and ;; limitations under the License. (ns backtype.storm.daemon.nimbus + (:import [org.apache.thrift.server THsHaServer THsHaServer$Args]) + (:import [org.apache.thrift.protocol TBinaryProtocol TBinaryProtocol$Factory]) + (:import [org.apache.thrift.exception]) + (:import [org.apache.thrift.transport TNonblockingServerTransport TNonblockingServerSocket]) + (:import [org.apache.commons.io FileUtils]) (:import [java.nio ByteBuffer] - [java.util Collections]) - (:import [java.io FileNotFoundException]) + [java.util Collections HashMap]) + (:import [java.io FileNotFoundException File FileOutputStream]) (:import [java.nio.channels Channels WritableByteChannel]) (:import [backtype.storm.security.auth ThriftServer ThriftConnectionType ReqContext AuthUtils]) (:use [backtype.storm.scheduler.DefaultScheduler]) (:import [backtype.storm.scheduler INimbus SupervisorDetails WorkerSlot TopologyDetails Cluster Topologies SchedulerAssignment SchedulerAssignmentImpl DefaultScheduler ExecutorDetails]) - (:import [backtype.storm.generated AuthorizationException GetInfoOptions - NumErrorsChoice]) - (:use [backtype.storm bootstrap util]) - (:use [backtype.storm.config :only [validate-configs-with-schemas]]) + (:import [backtype.storm.utils TimeCacheMap TimeCacheMap$ExpiredCallback Utils ThriftTopologyUtils + BufferFileInputStream]) + (:import [backtype.storm.generated NotAliveException AlreadyAliveException StormTopology ErrorInfo + ExecutorInfo InvalidTopologyException Nimbus$Iface Nimbus$Processor SubmitOptions TopologyInitialStatus + KillOptions RebalanceOptions ClusterSummary SupervisorSummary TopologySummary TopologyInfo + ExecutorSummary AuthorizationException GetInfoOptions NumErrorsChoice]) + (:import [backtype.storm.daemon Shutdownable]) + (:use [backtype.storm util config log timer]) + (:require [backtype.storm [cluster :as cluster] [stats :as stats]]) + (:require [clojure.set :as set]) + (:import [backtype.storm.daemon.common StormBase Assignment]) +; (:use [backtype.storm.config :only [validate-configs-with-schemas]]) --- End diff -- Everything at the top of this chunk that's removed is included in the new bit (except for bootstrap) > Remove bootstrap macro from Clojure codebase > -------------------------------------------- > > Key: STORM-441 > URL: https://issues.apache.org/jira/browse/STORM-441 > Project: Apache Storm > Issue Type: Improvement > Reporter: Dane Hammer > Priority: Trivial > > The bootstrap macro in backtype.storm.bootstrap is purely a convenience for > importing/using/requiring a large number of dependencies, but it's not used > for anything else. It removes those imports/uses/requires from the namespace > form, making it harder to track down where a definition is coming from, which > defeats some IDE tools. > I propose removing it entirely, making the Clojure part of the codebase more > readable and updated to current conventions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)