[
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14314768#comment-14314768
]
ASF GitHub Bot commented on STORM-534:
--------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/394#issuecomment-73769844
I have a few questions. First why are we storing the nimbus version as
JSON in zookeeper? The way the code is written to store the data in ZK we
start off with the raw values. We put them in a thrift object, and then
convert them to JSON to store them. To pull it back with the UI it asks nimbus
to get the cluster info which results in a zookeeper call to get the JSON
version string which is converted to thrift, sent back to the UI which converts
it back to JSON again. It feels like there are a lot of unnecessary steps. Can
we just store it as thrift in ZK and only convert to JSON for the final UI call?
I would also prefer to have clients pick the nimbus server to use as part
of nimbus HA https://github.com/apache/storm/pull/354 it fits better there.
Perhaps we really should just wait for the HA code to go in before putting in
the version number info. With this change we get half of HA but not all of it.
> Store Nimbus Server Information in zookeeper path
> {storm.zookeeper.root}/nimbus
> -------------------------------------------------------------------------------
>
> Key: STORM-534
> URL: https://issues.apache.org/jira/browse/STORM-534
> Project: Apache Storm
> Issue Type: Improvement
> Affects Versions: 0.10.0
> Reporter: caofangkun
> Assignee: caofangkun
> Priority: Minor
>
> 1) {nimbus.host} {nimbus.thrift.port} {storm.version} will be stored in
> {storm.zookeeper.root}/nimbus like "localhost:8826:0.9.3-r1234"
> 2) Storm Clients only need to configure {storm.zookeeper.root} to get Nimbus
> Server Information, Configuration like {nimbus.host} {nimbus.thrift.port}
> {storm.version} will be ignored
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
