[ https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14315118#comment-14315118 ]
ASF GitHub Bot commented on STORM-634: -------------------------------------- Github user Parth-Brahmbhatt commented on a diff in the pull request: https://github.com/apache/storm/pull/414#discussion_r24459097 --- Diff: storm-core/src/jvm/backtype/storm/serialization/ThriftSerializationDelegate.java --- @@ -0,0 +1,52 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package backtype.storm.serialization; + +import org.apache.thrift.TBase; +import org.apache.thrift.TDeserializer; +import org.apache.thrift.TException; +import org.apache.thrift.TSerializer; + +import java.util.Map; + +public class ThriftSerializationDelegate implements SerializationDelegate { --- End diff -- @revans2 I am sorry I am not sure what you mean when you say "topology serialization moved out". StormTopology is a thrift structure so I think we can use thriftSerializationDelegate. The Spouts and Bolts have Component structures which are just serialized java bytes. Do you mean every place where we are just calling "get_serialized_java" on thrift instances should use java serialization? I think that makes sense and I can make that change. Let me know if I misunderstood your comment. > Storm should support rolling upgrade/downgrade of storm cluster. > ---------------------------------------------------------------- > > Key: STORM-634 > URL: https://issues.apache.org/jira/browse/STORM-634 > Project: Apache Storm > Issue Type: Improvement > Reporter: Parth Brahmbhatt > Assignee: Parth Brahmbhatt > > Currently when a new version of storm is released in order to upgrade > existing storm clusters users need to backup their existing topologies , kill > all the topologies , perform the upgrade and resubmit all the topologies. > This is painful and results in downtime which may not be acceptable for > "Always alive" production systems. > Storm should support a rolling upgrade/downgrade deployment process to avoid > these downtimes and to make the transition to a different version effortless. > Based on my initial attempt the primary issue seem to be the java > serialization used to serialize java classes like StormBase, Assignment, > WorkerHeartbeat which is then stored in zookeeper. When deserializing if the > serial versions do not match the deserialization fails resulting in processes > just getting killed indefinitely. We need to change the Utils/serialize and > Utils/deserialize so it can support non java serialization mechanism like > json. -- This message was sent by Atlassian JIRA (v6.3.4#6332)