Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/421#discussion_r24511333
--- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
@@ -257,7 +258,9 @@
(if as-user
(worker-launcher-and-wait conf user ["signal" pid "9"] :log-prefix
(str "kill -15 " pid))
(kill-process-with-sig-term pid)))
- (if-not (empty? pids) (sleep-secs 1)) ;; allow 1 second for execution
of cleanup threads on worker.
+ (if-not (empty? pids) (do
+ (log-message "Sleep " shutdown-sleep-secs "
seconds for execution of cleanup threads on worker.")
+ (sleep-secs shutdown-sleep-secs)))
--- End diff --
To clean this up a tiny bit, this can be:
```clojure
(when-not (empty? pids)
(log-message ...)
(sleep-secs ...))
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
