[
https://issues.apache.org/jira/browse/STORM-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14327222#comment-14327222
]
ASF GitHub Bot commented on STORM-680:
--------------------------------------
GitHub user jayapriya90 opened a pull request:
https://github.com/apache/storm/pull/435
STORM-680: storm-kafka fails to compile with JDK 1.6
Replaced Long.compare() method of JDK 7 with compareTo() method of JDK 6.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jayapriya90/storm STORM-680
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/435.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #435
----
commit 2dd091d17c0953ddd6f863a2825cb90ec7d48978
Author: Jayapriya Surendran <priya7...@gmail.com>
Date: 2015-02-19T10:25:39Z
STORM-680: storm-kafka fails to compile with JDK 1.6
----
> storm-kafka fails to compile with JDK 1.6
> -----------------------------------------
>
> Key: STORM-680
> URL: https://issues.apache.org/jira/browse/STORM-680
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-kafka
> Affects Versions: 0.10.0
> Reporter: jayapriya surendran
> Assignee: jayapriya surendran
> Priority: Minor
> Labels: easyfix
>
> ExponentialBackoffMsgRetryManager.java uses Long.compare(long1, long2) method
> which is specific to JDK 7.
> {code}
> public int compare(MessageRetryRecord record1, MessageRetryRecord record2) {
> return Long.compare(record1.retryTimeUTC, record2.retryTimeUTC);
> }
> {code}
> As per the comment in this commit
> https://github.com/apache/storm/commit/fd066985a74c3140f61a465cfc49c83a6ddfa713
> we should enforce JDK 1.7 as the minimum requirement for storm-kafka.
> Alternate fix is to change Long.compare() method to Long.compareTo() which is
> compatible with JDK 1.6.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
