Github user ptgoetz commented on the pull request:

    https://github.com/apache/storm/pull/434#issuecomment-77397949
  
    +1. The diffs of `storm` vs. `storm.py` are minimal and related to windows 
compatibility.
    
    For easy reference, here they are:
    
    ```
    $ diff -w storm storm.py
    37a38,40
    > def is_windows():
    >     return sys.platform.startswith('win')
    >
    174c177
    <         JAVA_CMD, jvmtype, get_config_opts(),
    ---
    >         "java", jvmtype, get_config_opts(),
    184c187
    <     else:
    ---
    >     elif is_windows():
    186a190,191
    >     else:
    >         os.execvp(JAVA_CMD, all_args)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to