[
https://issues.apache.org/jira/browse/STORM-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349040#comment-14349040
]
ASF GitHub Bot commented on STORM-675:
--------------------------------------
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/434#issuecomment-77397949
+1. The diffs of `storm` vs. `storm.py` are minimal and related to windows
compatibility.
For easy reference, here they are:
```
$ diff -w storm storm.py
37a38,40
> def is_windows():
> return sys.platform.startswith('win')
>
174c177
< JAVA_CMD, jvmtype, get_config_opts(),
---
> "java", jvmtype, get_config_opts(),
184c187
< else:
---
> elif is_windows():
186a190,191
> else:
> os.execvp(JAVA_CMD, all_args)
```
> Allow users to have storm-env.sh under config dir to set custom JAVA_HOME and
> other env variables
> -------------------------------------------------------------------------------------------------
>
> Key: STORM-675
> URL: https://issues.apache.org/jira/browse/STORM-675
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Sriharsha Chintalapani
> Assignee: Sriharsha Chintalapani
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
