Github user Parth-Brahmbhatt commented on a diff in the pull request:

    https://github.com/apache/storm/pull/458#discussion_r26232904
  
    --- Diff: external/storm-jdbc/README.md ---
    @@ -13,14 +13,39 @@ public interface JdbcMapper  extends Serializable {
     }
     ```
     
    -The `getColumns()` method defines how a storm tuple maps to a list of 
columns representing a row in a database.
    +The `getColumns()` method defines how a storm tuple maps to a list of 
columns representing a row in a database. 
    +**The order of the returned list is important. The place holders in the 
supplied queries are resolved in the same order as returned list.**
    +For example if the user supplied insert query is `insert into table 
user(user_id, user_name, create_date) values (?,?, now())` the 1st item 
    --- End diff --
    
    I had an extra "table" in it, fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to