[
https://issues.apache.org/jira/browse/STORM-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357268#comment-14357268
]
ASF GitHub Bot commented on STORM-681:
--------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/436#issuecomment-78316257
I just had the one comment. As for the date in the generated files I see
two options.
1) We remove it with a sed script. It is optional, and thrift is not
following the formatting convention for it anyways
2) We eventually move to generating the code for the build each time.
I don't think either of these should be something we worry about now. The
thrift code changes rarely enough that I am fine with ignoring it until it is a
problem.
> Auto insert license header with genthrift.sh
> --------------------------------------------
>
> Key: STORM-681
> URL: https://issues.apache.org/jira/browse/STORM-681
> Project: Apache Storm
> Issue Type: Improvement
> Affects Versions: 0.10.0, 0.9.3-rc2
> Reporter: Kai Sasaki
> Assignee: Kai Sasaki
> Priority: Minor
> Labels: documentaion, thrift
>
> Current genthrift.sh does not insert license headers into generated source
> codes. These java codes and python codes should have license headers.
> And documentation about this command.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
