Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/451#issuecomment-78393165
The code looks fine to me. My only comment is that it would be nice to
have a default in most of the case statements, mostly as defensive programming
so if something gets off we wold get an error instead of falling through and
ignoring the tuples.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
