Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/445#discussion_r26266419
--- Diff:
storm-core/src/jvm/backtype/storm/security/auth/authorizer/SimpleACLAuthorizer.java
---
@@ -96,7 +101,10 @@ public boolean permit(ReqContext context, String
operation, Map topology_conf) {
}
if (_userCommands.contains(operation)) {
- return true;
+ if (_nimbusUsers.size() > 0 && _nimbusUsers.contains(user))
+ return true;
+ else if (_nimbusUsers.size() == 0)
+ return true;
--- End diff --
I personally think
```
return _nimbusUsers.size() == 0 || _nimbusUsers.contains(user);
```
is more readable than what is here, but this is really minor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
