Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/436#discussion_r26235414
--- Diff: storm-core/src/genthrift.sh ---
@@ -17,6 +17,16 @@
rm -rf gen-javabean gen-py py
rm -rf jvm/backtype/storm/generated
thrift7 --gen java:beans,hashcode,nocamel --gen py:utf8strings storm.thrift
+for file in gen-javabean/backtype/storm/generated/* ; do
+ cat java_license_header.txt ${file} > ${file}.tmp
+ mv ${file}.tmp ${file}
+done
+cat py_license_header.txt gen-py/__init__.py > gen-py/__init__.py.tmp
+mv gen-py/__init__.py.tmp gen-py/__init__.py
+for file in gen-py/storm/* ; do
+ cat py_license_header.txt ${file} > ${file}.tmp
+ mv ${file}.tmp ${file}
--- End diff --
Could we include a `-f` on the mv command? I know a lot of us have mv
configured as an alias to `mv -i` to avoid unexpected overwrites and this would
cause problems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
