[ 
https://issues.apache.org/jira/browse/STORM-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381914#comment-14381914
 ] 

ASF GitHub Bot commented on STORM-587:
--------------------------------------

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/475#issuecomment-86529303
  
    -1, I know it is convoluted the path through the code for this, but ID is 
already the topology name.  I don't see a reason to break backwards 
compatibility to have the topology name in there twice.
    
    Please don't do topology id either, because then state would never be saved 
from one run of a trident topology to another.  The best we could do is to 
isolate it by user name.


> trident transactional state in zk should be namespaced with topology id
> -----------------------------------------------------------------------
>
>                 Key: STORM-587
>                 URL: https://issues.apache.org/jira/browse/STORM-587
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Parth Brahmbhatt
>            Assignee: Sriharsha Chintalapani
>
> Currently when a trident transaction spout is initialized it creates a node 
> in zk under /transactional with the spout name as the node's name. This is 
> pretty dangerous as any other topology can be submitted with same spout name 
> and  now these 2 spouts will be overwriting each other's states. I believe it 
> is better to namespace this with topologyId just like all other zk entries 
> under /storm.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to