Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/349#discussion_r27418768
--- Diff: storm-core/src/clj/backtype/storm/daemon/worker.clj ---
@@ -302,9 +301,8 @@
port)
]
)))
- (write-locked (:endpoint-socket-lock worker)
- (reset! (:cached-task->node+port worker)
- (HashMap. my-assignment)))
--- End diff --
We should not extend the write lock, we should check tasks->node+port in
the read lock when we are sending. See
[comment](https://github.com/apache/storm/pull/349#issuecomment-87778672)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
