[ https://issues.apache.org/jira/browse/STORM-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481286#comment-14481286 ]
ASF GitHub Bot commented on STORM-745: -------------------------------------- GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/506 [STORM-745] fix storm.cmd to evaluate 'shift' correctly with 'storm jar' Please refer https://issues.apache.org/jira/browse/STORM-745 to see more details. The problem is, shift doesn't evaluated before calling goto. I found the hint from http://ss64.com/nt/shift.html. ``` The SHIFT command will not work within parenthesis/brackets, so place all your command line arguments in variables before running any FOR commands or other bracketed expressions. Or use the CALL syntax as explained in this forum thread. ``` Just calling goto first resolves it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/HeartSaVioR/storm STORM-745 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/506.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #506 ---- commit ad0d0d32dbfe06f8b7a40ba7205dddcfe0099a7b Author: Jungtaek Lim <kabh...@gmail.com> Date: 2015-04-06T14:53:31Z fix storm.cmd to evaluate 'shift' correctly with 'storm jar' ---- > Second Commandline Parameter passed to the main class is skipped when run in > windows > ------------------------------------------------------------------------------------ > > Key: STORM-745 > URL: https://issues.apache.org/jira/browse/STORM-745 > Project: Apache Storm > Issue Type: Bug > Affects Versions: 0.9.3-rc2, 0.9.4 > Environment: Windows Only > Reporter: jishnu > Labels: 2nd, command-line, parameter, skipping, windows > > Always the second parameter is getting skipped. > E:\target>storm jar StormZeroMQ.jar com.wipro.bdas.zeromq.ZMQTopology value1 > value2 value3 value4 value5 > Output > I=0 value=value1 > I=1 value=value3 > I=2 value=value4 > I=3 value=value5 > public class ZMQTopology { > public static void main(String[] args) throws AlreadyAliveException, > InvalidTopologyException { > for(int i=0;i<(args.length);i++) > { System.out.println("I=" +i+ " > value="+args[i]); > } > I am using the apache storm pre-built for windows. > After some amount of debugging I could find that it happens only with windows > machine . I was able to reproduce the error in 2 windows machine. With both > 0.9.3 and 0.9.4 .In Linux machine I could see command line parameters working > perfectly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)