Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/442#issuecomment-90122615
Overall things look fairly good. The only issue is that we are adding in
new data to the heartbeat. If we want to be able to do a rolling upgrade we
need to make sure that the new stat change is optional, and that we don't
expect it to always be there when we read. For example there is a topology up
and running. If nimbus is upgraded before any of the workers are, nimbus will
crash because the new data is not there. Similarly if the ui is updated before
nimbus is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
