[
https://issues.apache.org/jira/browse/STORM-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482227#comment-14482227
]
ASF GitHub Bot commented on STORM-750:
--------------------------------------
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/507#issuecomment-90290248
We should update the wording of the bylaws, then. I read through them when
this went in and (apparently) misinterpreted them.
The rules for code changes state both: "The code can be committed after the
first +1" and "Minimum Length: 1 day from initial patch"
I thought, like @revans2, that we'd dropped the 1-day waiting for the
retroactive -1. I'm fine with either, but whichever we choose, we should make
it more clear in the wording of the bylaws.
> Set Serialization Id for Config
> -------------------------------
>
> Key: STORM-750
> URL: https://issues.apache.org/jira/browse/STORM-750
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Labels: newbie
> Fix For: 0.11.0
>
>
> We have had several customers write bolts or spouts that don't do the right
> thing and end up caching the Config somewhere in the bolt or spout instance.
> Sometimes in odd ways through anonymous inner classes that should have been
> static but were not and debugging them because of the bad java serialization
> errors is really hard.
> Instead of beating on them to clean up these references every time we upgrade
> a cluster, or force them to keep their client perfectly in sync with the
> server, I propose that we set the serialization id for Config. Config stores
> no state except in the parent class so it really should not matter if we add
> more methods to it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
