Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/508#issuecomment-91075470
@revans2 Regarding timeout, it would be better to use TEST-TIMEOUT-MS on
timeout value.
Just a two cents, wait-for-condition doesn't treat timeout so it could be
stuck.
So tests should use while-timeout unless wait-for-condition does take care
of timeout.
While while-timeout provides more informations on timeout, it would be
better for wait-for-condition use while-timeout, too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
