[
https://issues.apache.org/jira/browse/STORM-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486494#comment-14486494
]
ASF GitHub Bot commented on STORM-757:
--------------------------------------
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/508#issuecomment-91084410
@nathanmarz To be valid, a veto (-1) must be accompanied by a
justification. Can you elaborate on your objections?
If you're just looking for more information, then a -0 might be more
appropriate. I'm sure any Committer would seek to address your concerns before
merging. Vetoes are rather heavy-handed and can be disruptive. If you feel
strongly that this patch should be blocked, then you need to explain why, and
be ready and willing to support or retract the veto.
> Simulated time can leak out on errors
> -------------------------------------
>
> Key: STORM-757
> URL: https://issues.apache.org/jira/browse/STORM-757
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
>
> with-simulated-time does not use try-finally so on any error simulated time
> can be left on in the tests leading to tests hanging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
