[ 
https://issues.apache.org/jira/browse/STORM-512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497827#comment-14497827
 ] 

ASF GitHub Bot commented on STORM-512:
--------------------------------------

Github user miguno commented on the pull request:

    https://github.com/apache/storm/pull/275#issuecomment-93690832
  
    Since KafkaBolt is extending BaseRichBolt, I think we should perform a 
`collector.ack(input)` before `return`.  Tick tuples must be acked like 
"normal" tuples.
    
    ```
    public class KafkaBolt<K, V> extends BaseRichBolt {
    
        public void execute(Tuple input) {
            if (TupleUtils.isTick(input)) {
              return; // Do not try to send ticks to Kafka
            }
            ...
        }
    ```


> KafkaBolt doesn't handle ticks properly
> ---------------------------------------
>
>                 Key: STORM-512
>                 URL: https://issues.apache.org/jira/browse/STORM-512
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Niels Basjes
>            Assignee: Niels Basjes
>             Fix For: 0.11.0
>
>
> I found that when using the KafkaBolt the tick tuples are not handled 
> properly. They should be ignored and the reality is that they are not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to