[
https://issues.apache.org/jira/browse/STORM-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499260#comment-14499260
]
ASF GitHub Bot commented on STORM-790:
--------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/527
STORM-790 Log "task is null" instead of let worker died when task is null
in transfer-fn
When task is null in transfer-fn, creating TaskMessage leads NPE.
Please refer https://issues.apache.org/jira/browse/STORM-770 and
https://issues.apache.org/jira/browse/STORM-790.
Thanks!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-790
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/527.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #527
----
commit 14477f4412f4adfaf42367e8a697e1a17b7dfb8e
Author: Jungtaek Lim <[email protected]>
Date: 2015-04-17T05:09:39Z
Log "task is null" instead of let worker died
* when task is null in transfer-fn, creating TaskMessage leads NPE
----
> Log "task id is null" instead of let worker died (NPE in consumeBatchToCursor)
> ------------------------------------------------------------------------------
>
> Key: STORM-790
> URL: https://issues.apache.org/jira/browse/STORM-790
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.9.2-incubating, 0.9.3, 0.10.0, 0.9.4, 0.11.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> In STORM-770, some users have observed that worker suddenly died with NPE in
> consumeBatchToCursor().
> Looks like it can occur when "task" in "mk-transfer-fn" is null.
> It may not be an issue before 0.9.2-incubating, since worker just ignores
> that tuple.
> Please see
> https://issues.apache.org/jira/browse/STORM-770?focusedCommentId=14496199&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14496199.
> Before finding root cause of this issue, it would be better to let worker not
> killed by this issue but just log with WARN or ERROR level.
> It really makes sense cause before 0.9.2 Storm silently ignores tuple, and
> with Guaranteeing Message Processing, after timed-out tuple will be replayed.
> (It isn't applied to non-ack)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
