Github user dan-blanchard commented on a diff in the pull request:

    https://github.com/apache/storm/pull/525#discussion_r28696404
  
    --- Diff: storm-core/src/jvm/backtype/storm/task/TopologyContext.java ---
    @@ -205,32 +217,65 @@ public Object getTaskData(String name) {
         public void setExecutorData(String name, Object data) {
             _executorData.put(name, data);
         }
    -    
    +
         public Object getExecutorData(String name) {
             return _executorData.get(name);
    -    }    
    -    
    +    }
    +
         public void addTaskHook(ITaskHook hook) {
             hook.prepare(_stormConf, this);
             _hooks.add(hook);
         }
    -    
    +
         public Collection<ITaskHook> getHooks() {
             return _hooks;
         }
    +
    +    public Object groupingToJSONableObject(Grouping grouping) {
    --- End diff --
    
    Good point. I'll fix that.  I also wasn't sure how much everyone would like 
my made-up word "JSONable".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to