[ 
https://issues.apache.org/jira/browse/STORM-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509647#comment-14509647
 ] 

ASF GitHub Bot commented on STORM-704:
--------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/486#discussion_r28995728
  
    --- Diff: dev-tools/travis/travis-build.sh ---
    @@ -0,0 +1,35 @@
    +#!/bin/bash
    +#  Licensed under the Apache License, Version 2.0 (the "License");
    +#  you may not use this file except in compliance with the License.
    +#  You may obtain a copy of the License at
    +#
    +#    http://www.apache.org/licenses/LICENSE-2.0
    +#
    +#  Unless required by applicable law or agreed to in writing, software
    +#  distributed under the License is distributed on an "AS IS" BASIS,
    +#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +#  See the License for the specific language governing permissions and
    +#  limitations under the License.
    +
    +STORM_SRC_ROOT_DIR=$1
    +
    +TRAVIS_SCRIPT_DIR=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )
    +
    +cd ${STORM_SRC_ROOT_DIR}
    +
    +# Travis CI doesn't allow stdout bigger than 4M, so we have to reduce log 
while running tests
    +export LOG_LEVEL=WARN
    +# We should concern that Travis CI could be very slow cause it uses VM
    +export export STORM_TEST_TIMEOUT_MS=100000
    +
    +mvn clean test
    --- End diff --
    
    After some new changes went in around packaging shell dependencies this 
need to be changed to 
    ```mvn clean package```
    or maven gets angry about unpacking something that was not already packaged


> Apply Travis CI
> ---------------
>
>                 Key: STORM-704
>                 URL: https://issues.apache.org/jira/browse/STORM-704
>             Project: Apache Storm
>          Issue Type: Improvement
>         Environment: Travis CI
>            Reporter: Jungtaek Lim
>            Assignee: Jungtaek Lim
>            Priority: Minor
>
> Now Apache Storm takes advantage of Github, we can apply Travis CI to some 
> more advantages.
> - Build matrix
> -- Travis CI supports various JDK versions (openjdk6, openjdk7, oraclejdk7, 
> oraclejdk8), and it can be tested separately.
> - Build automatically
> -- pushed new commits, any new PRs
> - Integrated with Github
> -- Contributors can see his/her PR breaks compilation / test in some minutes.
> -- If he/she adds commits to PR, Travis builds it automatically and update 
> build result.
> Please see [https://travis-ci.org/xetorthio/jedis] for example.
> There're some hurdles applying Travis CI to Apache Storm project, but we can 
> overcome these and finally get great CI.
> Current hurdles
> - asfgit should manage Travis CI setup for the first time
> -- other Apache projects already did it by requesting it to INFRA
> --- ex. [https://issues.apache.org/jira/browse/INFRA-6161]
> - Travis CI restricts stdout with 4M which is too small for Storm maven 
> output.
> -- Change log level in tests to WARN
> - In storm-core, we can't see tests failure information on stdout cause it 
> just prints 'clojure failed'.
> -- We need to find a way to upload surefire / clojure tests report files to 
> somewhere, and uploaded files should be visible easily.
> --- Travis supports uploading artifacts to S3 by 
> [https://github.com/travis-ci/artifacts], but S3 is not free.
> -- I'm not familiar with Clojure, but can we print tests summary with clojure 
> tests as same as Java junit tests?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to