[
https://issues.apache.org/jira/browse/STORM-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528548#comment-14528548
]
ASF GitHub Bot commented on STORM-809:
--------------------------------------
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/544#issuecomment-99100130
LGTM.
Regarding NotNullPosIntegerValidator, it may be better to add some tests on
config_test.clj.
> topology.message.timeout.secs should not allow for null or <= 0 values
> ----------------------------------------------------------------------
>
> Key: STORM-809
> URL: https://issues.apache.org/jira/browse/STORM-809
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
>
> topology.message.timeout.secs has bad things happen if it is set to null or
> <= 0. If it is null killing or rebalancing a topology without providing a
> timeout results in an NPE. <= 0 causes other periodic things to run too
> frequently.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
