Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/521#discussion_r30513365
--- Diff: storm-core/src/clj/backtype/storm/daemon/worker.clj ---
@@ -139,12 +139,12 @@
(.add local pair)
;;Using java objects directly to avoid performance
issues in java code
- (let [node+port (get @task->node+port task)]
- (when (not (.get remoteMap node+port))
- (.put remoteMap node+port (ArrayList.)))
- (let [remote (.get remoteMap node+port)]
+ (let []
+ (when (not (.get remoteMap task))
+ (.put remoteMap task (ArrayList.)))
+ (let [remote (.get remoteMap task)]
(.add remote (TaskMessage. task (.serialize
serializer tuple)))
- ))))
+ ))))
--- End diff --
@d2r
Accessing task->node+port from these lines is root of this problem since it
can be changed during preparing for transfer. So we should change current
implementation to not accessing task->node+port.
It should be grouped by destination (node and port) within read lock.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
