[
https://issues.apache.org/jira/browse/STORM-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561530#comment-14561530
]
ASF GitHub Bot commented on STORM-737:
--------------------------------------
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/521#issuecomment-106038982
Tested with https://github.com/yahoo/storm-perf-test with the following
arguments:
```
--ack --bolt 4 --name test -l 1 -n 1 --workers 4 --spout 3 --testTimeSec 900
-c topology.max.spout.pending=1092 --messageSize 10
```
OK, I found both the data-rate and the latency are improved with this patch
in my tests:
master at 512d3def:
Throughput in MB/s:
max: 0.1519711812
99: 0.1510783919
90: 0.1276066783
50: 0.1100190481
min: 0.07258733114
Complete Latency/10m: 265ms
This PR 85c5096e merged to master at 512d3def:
Throughput in MB/s:
max: 0.1760864258
99: 0.1707911174
90: 0.1550458272
50: 0.1419607798
min: 0.1128451029
Complete Latency/10m: 204ms
I am also fine with the changes.
+1
Thank you for your patience, @HeartSaVioR.
> Workers may try to send to closed connections
> ---------------------------------------------
>
> Key: STORM-737
> URL: https://issues.apache.org/jira/browse/STORM-737
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.9.2-incubating
> Reporter: Derek Dagit
>
> There is a race condition in the worker code that can allow for a send() to
> be called on a closed connection.
> [Discussion|https://github.com/apache/storm/pull/349#issuecomment-87778672]
> The assignment mapping from task -> node+port needs to be read and used in
> the read lock when sending, so that an accurate mapping is used that does not
> include any connections that are closed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
