[ 
https://issues.apache.org/jira/browse/STORM-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568263#comment-14568263
 ] 

ASF GitHub Bot commented on STORM-753:
--------------------------------------

Github user ptgoetz commented on the pull request:

    https://github.com/apache/storm/pull/504#issuecomment-107750135
  
    I'm +1, but with the understanding that I have not done any testing beyond 
unit tests. I would like to see additional Committer reviews before merging.


> [storm-redis] Let Redis*StateUpdater to have additional mapper - converting 
> Redis key/value to Storm Values
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: STORM-753
>                 URL: https://issues.apache.org/jira/browse/STORM-753
>             Project: Apache Storm
>          Issue Type: Improvement
>    Affects Versions: 0.10.0, 0.11.0
>            Reporter: Jungtaek Lim
>            Assignee: Jungtaek Lim
>
> https://issues.apache.org/jira/browse/STORM-723?focusedCommentId=14381626&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14381626
> Currently Redis*StateUpdater use key prefix to let users customize key name.
> Since it's less powerful, how about having 2 mappers which one is for 
> converting tuple to key/value, and another one is for converting value from 
> Redis to Storm Values?
> You can refer 
> https://github.com/apache/storm/blob/master/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseState.java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to