[
https://issues.apache.org/jira/browse/STORM-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602921#comment-14602921
]
ASF GitHub Bot commented on STORM-912:
--------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/604#discussion_r33358774
--- Diff: storm-core/src/clj/backtype/storm/ui/core.clj ---
@@ -293,10 +293,17 @@
(bolt-comp-summs id))]
(sort-by #(-> ^ExecutorSummary % .get_executor_info .get_task_start)
ret)))
-(defn worker-log-link [host port topology-id]
+(defn worker-log-link [host port topology-id secure?]
(let [fname (logs-filename topology-id port)]
- (url-format (str "http://%s:%s/log?file=%s";)
- host (*STORM-CONF* LOGVIEWER-PORT) fname)))
+ (if secure?
--- End diff --
Actually I just had a thought. We probably want this to be
```
(if (and secure? (*STORM-CONF* LOGVIEWER-PORT))
...)
```
That way someone is not required to secure their logviewers if they secure
the main UI.
> Support SSL on Logviewer
> ------------------------
>
> Key: STORM-912
> URL: https://issues.apache.org/jira/browse/STORM-912
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Kyle Nusbaum
> Priority: Minor
>
> Support SSL on the logviewer like it is in the UI.
> Also detect what method we're using and make sure logviewer links in the UI
> are pointing to the appropriate Logviewer endpoint.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
