Github user knusbaum commented on a diff in the pull request:

    https://github.com/apache/storm/pull/617#discussion_r34603678
  
    --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
    @@ -59,20 +59,16 @@
      * - Connecting and reconnecting are performed asynchronously.
      *     - Note: The current implementation drops any messages that are 
being enqueued for sending if the connection to
      *       the remote destination is currently unavailable.
    - * - A background flusher thread is run in the background.  It will, at 
fixed intervals, check for any pending messages
    - *   (i.e. messages buffered in memory) and flush them to the remote 
destination iff background flushing is currently
    - *   enabled.
      */
     public class Client extends ConnectionWithStatus implements 
IStatefulObject {
    +    private static final long PENDING_MESSAGES_FLUSH_TIMEOUT_MS = 600000L;
    --- End diff --
    
    That's fine with me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to