Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/573#issuecomment-125113030
@sweetest
Please check comments which doesn't show as outdated. You seems missed some
comments.
Other things are fine.
And I agree that ES is not a queue so it may not feel comfortable to
implement Spout for ES.
Overall I'm fine for merging this in.
As @harshach want to volunteer this module, I'd like @harshach to take a
look, too.
When @harshach confirms it's good to merge, I'll merge to master.
And please add me and @harshach as Committer Sponsors.
You can refer
https://github.com/apache/storm/blob/master/external/storm-redis/README.md to
see how to add.
Thanks for contributing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
