Github user jack6215 commented on the pull request:
https://github.com/apache/storm/pull/669#issuecomment-129416336
topicAsStreamId flag should be judged outside the loop for better
performance.
like this:
if (_spoutConfig.topicAsStreamId) {
for (List<Object> tup : tups) {
collector.emit(_spoutConfig.topic, tup, new
KafkaMessageId(_partition, toEmit.offset));
}
break;
} else {
for (List<Object> tup : tups) {
collector.emit(tup, new KafkaMessageId(_partition,
toEmit.offset));
}
break;
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
