Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/670#issuecomment-129460417
  
    @harshach 
    Looks beautiful to me. And spots I reported seems be fixed.
    I looked at whole things and found new points to fix.
    
    downloads.html
    —
    - Download link for “Current Beta Release" is still pointed to 
0.10.0-beta, not 0.10.0-beta1.
    
    multi-language.html
    —
    - Adapters that implement this protocol exist for Ruby, Python, Javascript, 
Perl.
      - Link of Ruby, Python, Javascript are broken. It should link to 
storm-multilang module.
    
    documentation.html
    —
    - "#" anchor doesn't work, so when we move to link and back, it always 
points to "basics of storm".
    
    documentation.html#basic
    —
    - Javadoc link points to Nathan’s github repo. It should be replaced to 
recent javadoc.
    
    documentation/Serialization.html
    —
    - We should replace all links about Kyro to github, 
https://github.com/EsotericSoftware/kryo.
    
    documentation/Setting-up-a-Storm-cluster.html
    —
    - The Storm releases can be downloaded from here.
      - It would be better to link "Download" page instead of github releases.
    
    documentation/Clojure-DSL.html
    —
    - "backtype.storm.clojure" link points to 0.5.3 branch, which should point 
to master branch.
    - "Direct groupings" links to its page, "Clojure-DSL", which doesn't 
explain direct groupings. 
    
    documentation/Metrics.html
    —
    - "builtin metrics" and "builtin_metrics.clj" link points to specific 
commit, which would be better to point to master branch.
    
    documentation/Acking-framework-implementation.html
    —
    - "Storm's acker" and "execute method", and "put the record" link points to 
specific commit, which would be better to point to master branch.
    
    contribute/Contributing-to-Storm.html
    —
    - Modules built on top of Storm
      - Do we still support @stormprocessor? If not, it would like to guide 
him/her to become part of storm-external.
    
    Overall
    —
    - All links which point to javadoc are broken. Can I expect it will work 
when site resources are deployed to official site?
    - Minor: We would be better to create new page Kafka-and-Storm.html and 
replace Kestrel-and-Storm.html.
    - Minor: How about removing all documents which are based on older than 
0.9.0?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to