Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/675#discussion_r36824315
  
    --- Diff: storm-core/src/ui/public/templates/topology-page-template.html ---
    @@ -313,6 +320,10 @@
             </th>
             <th class="header">Last error
             </th>
    +           <th class="header">
    --- End diff --
    
    @caofangkun 
    Before that we need to establish code style for Java, HTML, etc. And have 
formatter file to let users applies it easily.
    
    For example, Jedis uses Eclipse Java formatter which HBase project is using.
    https://github.com/xetorthio/jedis/blob/master/hbase-formatter.xml
    And ```make format``` formats whole files, so any contributors can run that 
commands before commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to