[
https://issues.apache.org/jira/browse/STORM-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692858#comment-14692858
]
ASF GitHub Bot commented on STORM-949:
--------------------------------------
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/675#discussion_r36824315
--- Diff: storm-core/src/ui/public/templates/topology-page-template.html ---
@@ -313,6 +320,10 @@
</th>
<th class="header">Last error
</th>
+ <th class="header">
--- End diff --
@caofangkun
Before that we need to establish code style for Java, HTML, etc. And have
formatter file to let users applies it easily.
For example, Jedis uses Eclipse Java formatter which HBase project is using.
https://github.com/xetorthio/jedis/blob/master/hbase-formatter.xml
And ```make format``` formats whole files, so any contributors can run that
commands before commit.
> On the topology summary UI page, last shown error should have the time and
> date
> -------------------------------------------------------------------------------
>
> Key: STORM-949
> URL: https://issues.apache.org/jira/browse/STORM-949
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Reza Farivar
> Assignee: Boyang Jerry Peng
> Priority: Minor
>
> Without showing the time and date, it is not clear whether the error is a
> recent one or an old stale one.
> (Error text is colored red when it is in last 5 minutes, but this is not
> obvious and not enough information)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
