[ https://issues.apache.org/jira/browse/STORM-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699031#comment-14699031 ]
ASF GitHub Bot commented on STORM-854: -------------------------------------- Github user rohanag12 commented on a diff in the pull request: https://github.com/apache/storm/pull/669#discussion_r37159376 --- Diff: external/storm-kafka/src/jvm/storm/kafka/PartitionManager.java --- @@ -137,8 +137,14 @@ public EmitState next(SpoutOutputCollector collector) { } Iterable<List<Object>> tups = KafkaUtils.generateTuples(_spoutConfig, toEmit.msg); if (tups != null) { - for (List<Object> tup : tups) { - collector.emit(tup, new KafkaMessageId(_partition, toEmit.offset)); + if(_spoutConfig.topicAsStreamId) { + for (List<Object> tup : tups) { --- End diff -- @harshach Having the if condition check inside the for loop is a performance overhead. About renaming the variables, I did not name them. The original storm-kafka creators did. So I am not going to rename them now. > [Storm-Kafka] KafkaSpout can set the topic name as the output streamid > ----------------------------------------------------------------------- > > Key: STORM-854 > URL: https://issues.apache.org/jira/browse/STORM-854 > Project: Apache Storm > Issue Type: Improvement > Components: storm-kafka > Affects Versions: 0.9.5 > Reporter: zhiwei > Fix For: 0.10.0 > > > KafkaSpout can set the topic name as the output streamid -- This message was sent by Atlassian JIRA (v6.3.4#6332)