Github user arunmahadevan commented on a diff in the pull request:

    https://github.com/apache/storm/pull/664#discussion_r37160568
  
    --- Diff: 
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/HdfsBolt.java ---
    @@ -80,6 +86,11 @@ public HdfsBolt addRotationAction(RotationAction action){
             return this;
         }
     
    +    public HdfsBolt withTickTupleIntervalSeconds(int interval) {
    --- End diff --
    
    Could give a more meaningful name to convey the actual usage (e.g 
`withFlushIntervalSeconds`). I think we need to have a default value for this 
to ensure a sync is `always` done even if user doesn't specify this option and 
also ensure the option value is within some lower and upper thresholds so that 
tuples are acked within TOPOLOGY_MESSAGE_TIMEOUT_SECS and a sync doesn't happen 
too frequently.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to