[ 
https://issues.apache.org/jira/browse/STORM-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705087#comment-14705087
 ] 

ASF GitHub Bot commented on STORM-978:
--------------------------------------

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/693#discussion_r37540926
  
    --- Diff: 
external/storm-elasticsearch/src/main/java/org/apache/storm/elasticsearch/ElasticsearchGetRequest.java
 ---
    @@ -0,0 +1,10 @@
    +package org.apache.storm.elasticsearch;
    +
    +import org.elasticsearch.action.get.GetRequest;
    +
    +import backtype.storm.tuple.Tuple;
    +
    +public interface ElasticsearchGetRequest {
    +
    +    GetRequest extractFrom(Tuple tuple);
    --- End diff --
    
    @alexpanov It would be better to change parameter type, Tuple -> ITuple.


> [storm-elasticsearch] Introduces Lookup(or Query)Bolt which emits matched 
> documents from ES
> -------------------------------------------------------------------------------------------
>
>                 Key: STORM-978
>                 URL: https://issues.apache.org/jira/browse/STORM-978
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Jungtaek Lim
>            Assignee: Alex Panov
>
> storm-elasticsearch has features on storing document, not querying something.
> It would be better to have Lookup (or Query) Bolt for querying to ES and emit 
> matched documents, as other external modules did.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to