[
https://issues.apache.org/jira/browse/STORM-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712574#comment-14712574
]
ASF GitHub Bot commented on STORM-1007:
---------------------------------------
GitHub user wangli1426 opened a pull request:
https://github.com/apache/storm/pull/698
[STORM-1007] Isolate the code for metric collection and retrieval from
DisruptorQueue
I created an inner class QueueMetrics for DisruptorQueue. The QueueMetrics
class handles metric collection logics and exposes metric retrieval methods.
The benefits of such modification are twofold:
1. It improves the readability of the metric code.
2. It facilitates to add more metrics, such as average throughput and
element sojourn time. (That is because the data maintained for such
"stateful" metrics can reside in QueueMetrics rather than in DisruptorQueue. )
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wangli1426/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/698.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #698
----
commit 4337ebe6e2398073e9a238e88bd51ca7b76b3437
Author: wangli1426 <wangli1...@gmail.com>
Date: 2015-08-26T04:48:27Z
Created QueueMetrics inner class in DistruptorQueue to improve the
extendibility and the readability of the metrics code.
----
> Add more metrics to DisruptorQueue
> ----------------------------------
>
> Key: STORM-1007
> URL: https://issues.apache.org/jira/browse/STORM-1007
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Li Wang
> Assignee: Li Wang
> Original Estimate: 672h
> Remaining Estimate: 672h
>
> The metrics of the queues for each component are very helpful to reason about
> the performance issues of a topology.
> For instance, for the applications with strong time constraint (e.g., threat
> detection), if the elements in the input queue of a bolt have a long sojourn
> time, it indicates that the user should increase the parallelism of that bolt
> to reduce the processing delay.
> However, the metrics on the DisruptorQueue currently available are limited.
> More useful metrics, such as average sojourn time and average throughput are
> expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
