[
https://issues.apache.org/jira/browse/STORM-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14713482#comment-14713482
]
ASF GitHub Bot commented on STORM-994:
--------------------------------------
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/697#discussion_r37985888
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -359,23 +359,34 @@ public static Object
getSetComponentObject(ComponentObject obj) {
public static void downloadFromMaster(Map conf, String file, String
localFile) throws AuthorizationException, IOException, TException {
NimbusClient client = NimbusClient.getConfiguredClient(conf);
- download(client, file, localFile);
+ try {
+ download(client, file, localFile);
+ } finally {
+ client.close();
+ }
}
public static void downloadFromHost(Map conf, String file, String
localFile, String host, int port) throws IOException, TException,
AuthorizationException {
NimbusClient client = new NimbusClient (conf, host, port, null);
- download(client, file, localFile);
+ try {
+ download(client, file, localFile);
--- End diff --
Indentation seems mixed.
> Connection leak between nimbus and supervisors
> ----------------------------------------------
>
> Key: STORM-994
> URL: https://issues.apache.org/jira/browse/STORM-994
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.9.3, 0.10.0, 0.9.4, 0.9.5
> Reporter: Frantz Mazoyer
> Assignee: Frantz Mazoyer
> Priority: Minor
>
> Successive deploys/undeploys of topology(ies) may result in a connection leak
> between nimbus and its supervisors
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
